Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentrons-ai-client): send chat history instead user prompt #15226

Closed
wants to merge 10 commits into from

Conversation

koji
Copy link
Contributor

@koji koji commented May 20, 2024

Overview

send chat history to the backend instead only user prompt.

The currently opentrons-ai-client sends userPrompt (string) to the backend but we need to send the entire chat history to align with the application on HuggingFace.
https://huggingface.co/spaces/Opentrons/OpentronsAI-v0.0.5/blob/main/flexchatinterface.py
The sample data is in the ticket.

close AUTH-407 AUTH-414

Test Plan

Changelog

  • add a new atom chatHistoryAtom to store chatHistory

Review requests

Risk assessment

low

…nly user prompt

sned chat history to the backend instead only user prompt

close AUTH-407
@koji
Copy link
Contributor Author

koji commented May 20, 2024

  • need to deploy the latest backend
  • need to check backend log

@koji koji requested review from Elyorcv, ncdiehl11 and jerader May 20, 2024 20:14
@Elyorcv
Copy link
Contributor

Elyorcv commented May 21, 2024

@koji I think you also need to modify server function such that it accepts list rather currently string?

@koji
Copy link
Contributor Author

koji commented May 21, 2024

Reference

wait, server is not updated yet?
the format you shared in the Jira ticket might be different?

@Elyorcv
Copy link
Contributor

Elyorcv commented May 21, 2024

Reference

wait, server is not updated yet? the format you shared in the Jira ticket might be different?

If you see lines 10-11 at function.py you see ChatRequest. I assume that we need to change this one as well to account for the changes you are making. @y3rsh may comment on this.

@koji koji requested a review from y3rsh May 21, 2024 22:11
@koji
Copy link
Contributor Author

koji commented May 29, 2024

This will be resolved by #15288

@koji koji closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants